Re: [PATCH 32/33] Input: sis_i2c - Drop unnecessary call to i2c_set_clientdata and other changes

From: Dmitry Torokhov
Date: Wed Jan 18 2017 - 17:27:24 EST


On Wed, Jan 18, 2017 at 12:36:49PM -0800, Guenter Roeck wrote:
> There is no call to i2c_get_clientdata() or dev_get_drvdata().
> Drop the unnecessary call to i2c_set_clientdata().
>
> This conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
>
> - Drop i2c_set_clientdata()
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Applied, thank you.

> ---
> drivers/input/touchscreen/sis_i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/sis_i2c.c b/drivers/input/touchscreen/sis_i2c.c
> index 8d93f8c9a403..67c2563031d6 100644
> --- a/drivers/input/touchscreen/sis_i2c.c
> +++ b/drivers/input/touchscreen/sis_i2c.c
> @@ -316,7 +316,6 @@ static int sis_ts_probe(struct i2c_client *client,
> return -ENOMEM;
>
> ts->client = client;
> - i2c_set_clientdata(client, ts);
>
> ts->attn_gpio = devm_gpiod_get_optional(&client->dev,
> "attn", GPIOD_IN);
> --
> 2.7.4
>

--
Dmitry