Re: [PATCH 3/5] s390/pci: Move three assignments for the variable "rc" in clp_normal_command()

From: Christophe JAILLET
Date: Sun Jan 22 2017 - 02:59:38 EST


Le 21/01/2017 Ã 19:12, SF Markus Elfring a Ãcrit :
@@ -541,9 +543,8 @@ static int clp_normal_command(struct clp_req *req)
if (rc)
goto out_free;
- rc = -EFAULT;
if (copy_to_user(uptr, lpcb, PAGE_SIZE) != 0)
- goto out_free;
+ rc = -EFAULT;
rc = 0;

With this, we return 0 (success) on error.

CJ