Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

From: Michael Ellerman
Date: Tue Jan 24 2017 - 04:58:22 EST


Greg Kurz <groug@xxxxxxxx> writes:

> The kernel API does not use anything from this header file.

That's actually hard to prove in general, because pnv-pci.h includes
linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
asm/opal-api.h. At least four of which aren't included directly by
api.c.

But I'll take you word for it :)

cheers

> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 1b35e33d2434..bcc030eacab7 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -11,7 +11,6 @@
> #include <linux/slab.h>
> #include <linux/file.h>
> #include <misc/cxl.h>
> -#include <asm/pnv-pci.h>
> #include <linux/msi.h>
> #include <linux/module.h>
> #include <linux/mount.h>