Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross timestamps infrastructure

From: Richard Cochran
Date: Tue Jan 24 2017 - 06:35:59 EST


On Tue, Jan 24, 2017 at 09:23:29AM -0200, Marcelo Tosatti wrote:
> I'm resending v5 with native support for ->gettime and
> ->getcrosststamps.

And can you please drop the "fake" PTP_SYS_OFFSET stuff?

Here is another reason why this is illogical. The application can
choose how many samples to take during PTP_SYS_OFFSET. It will choose
more samples if it wants a better picture of the offsets, but in that
case the "fake" samples would cause more computation in the kernel for
no added benefit.

Thanks,
Richard