Re: [alsa-devel] [PATCH 6/7] dmasound_core: Move two assignments for the variable "ret" in state_open()
From: Clemens Ladisch
Date: Wed Jan 25 2017 - 02:47:55 EST
SF Markus Elfring wrote:
> A local variable was set to an error code in two cases before a concrete
> error situation was detected.
And why would that be a problem?
http://yarchive.net/comp/linux/error_jumps.html
> - ret = -EBUSY;
> - if (state.busy)
> + if (state.busy) {
> + ret = -EBUSY;
> goto out;
> + }
Regards,
Clemens