Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF

[Rafael J. Wysocki]

On Wed, Jan 25, 2017 at 1:49 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Jan 24, 2017 at 04:06:34PM -0800, Furquan Shaikh wrote:
>
>> Since regulator properties remain the same across OF and ACPI
>> regulators, this series of patches provides common routine for
>> obtaining regulation constraints from device tree and ACPI nodes. In
>
> As Lorenzo explained this is really not a good idea, ACPI has a power
> management model which is just being ignored here.  If you're producing
> systems using ACPI you really need to use ACPI in a joined up fashion
> rather than just blindly importing all DT bindings into ACPI.  While
> there are many areas where ACPI just doesn't do anything and as a result
> it does make sense to reuse existing DT bindings there are also plenty
> of areas where work has been done on the ACPI side.  Regulators and
> power management are definitely one of those areas.

This is exactly right. :-)

Thanks,
Rafael