Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module

[Marek Szyprowski]

Hi Krzysztof,


On 2017-01-25 20:50, Krzysztof Kozlowski wrote:
> On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote:
> > Exynos5433 LPASS module requires some clocks for proper operation with
> > power domain.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> > index 57c7bbeb65a7..16072c1c3ed3 100644
> > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> > @@ -1494,6 +1494,8 @@
> >   		audio-subsystem@11400000 {
> >   			compatible = "samsung,exynos5433-lpass";
> >   			reg = <0x11400000 0x100>, <0x11500000 0x08>;
> > +			clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> > +			clock-names = "sfr0_ctrl";
> You wrote that 6/7 depends on this. I prefer not to take DTS changes if
> the corresponding user (driver) is still under discussion because the
> bindings might change. I'll take it when bindings got acked or accepted.

Well, audio support in 4.9 is still not functional due to missing other
patches to ALSA SoC, so nothing will break as for now if we manage to get
this into v4.10.

> BTW, the 6/7 is a quite reasonable ABI break, but for the sake of
> documentation - why you did not continue with the patch for marking
> bidings as experimental/under-development?

Because I had no time to list all breaks, what was requested by Rob.


Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland