Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present

From: Joe Perches
Date: Thu Jan 26 2017 - 17:58:59 EST


On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
> Some Asus laptops that have an airplane-mode indicator LED, also have
> the WMI WLAN user bit set, and the following bits in their DSDT:

style trivia:

> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
[]
> @@ -2051,6 +2052,16 @@ static int asus_wmi_fan_init(struct asus_wmi *asus)
> return 0;
> }
>
> +static bool ashs_present(void)
> +{
> + int i;
> +
> + for (i = 0; strcmp(asus_wireless_ids[i].id, ""); i++)
> + if (acpi_dev_found(asus_wireless_ids[i].id))
> + return true;

The for loop would commonly have braces because of the
internal if.