Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

From: Thomas Hellstrom
Date: Fri Jan 27 2017 - 01:24:27 EST


On 01/27/2017 03:29 AM, Michel DÃnzer wrote:
> On 26/01/17 09:46 AM, Sinclair Yeh wrote:
>> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian KÃnig wrote:
>>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom:
>>>> On 01/25/2017 09:21 AM, Michel DÃnzer wrote:
>>>>> From: Michel DÃnzer <michel.daenzer@xxxxxxx>
>>>>>
>>>>> The current caching state may not be tt_cached, even though the
>>>>> placement contains TTM_PL_FLAG_CACHED, because placement can contain
>>>>> multiple caching flags. Trying to swap out such a BO would trip up the
>>>>>
>>>>> BUG_ON(ttm->caching_state != tt_cached);
>>>>>
>>>>> in ttm_tt_swapout.
>>>>>
>>>>> Cc: stable@xxxxxxxxxxxxxxx
>>>>> Signed-off-by: Michel DÃnzer <michel.daenzer@xxxxxxx>
>>>> Reviewed-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx>
>>> Reviewed-by: Christian KÃnig <christian.koenig@xxxxxxx>.
>> Reviewed-by: Sinclair Yeh <syeh@xxxxxxxxxx>
> Thanks for the reviews! Via which tree should we merge this?
>
>
I don't maintain a TTM tree any longer. Let's check with Daniel if he
can merge it through drm-misc.

/Thomas