Re: [linux-sunxi] Re: [PATCH v2 4/9] arm: dts: sun8i: split Allwinner H3 .dtsi

From: Maxime Ripard
Date: Fri Jan 27 2017 - 16:14:11 EST


On Sat, Jan 28, 2017 at 12:02:20AM +0800, Icenowy Zheng wrote:
>
> 2017å1æ27æ 23:55ä Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>åéï
> >
> > On Thu, Jan 26, 2017 at 11:48:54PM +0800, Icenowy Zheng wrote:
> > > - mmc0: mmc@01c0f000 {
> > > + mmc@01c0f000 {
> >
> > There's no point in removing the labels, and you can even use the
> > label-based syntax to reference them, instead of using the path.
>
> I think keeping a tree structure in sub dtsi file will make it more
> pretty and easy to use :-)

We're already using that syntax for all the DTS, so it won't be less
pretty than those.

And keeping a tree structure valid is not easier to use than, well,
not having to keep it.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature