Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver

[Benson Leung]

Hi Gwendal,

Overall, this looks good to me, but please make sure this is based on
upstream, and not the ChromeOS kernel trees.

On 01/30/2017 11:30 AM, Gwendal Grignou wrote:
> Add a kernel driver for GOOG0006, an ACPI driver reporting an event when
> the tablet switch status changes.
> 
> On an ACPI based convertible chromebook check evtest display tablet mode
> switch changes:
> Available devices:
> ..
> /dev/input/event3:      Tablet Mode Switch
> ..
> Testing ... (interrupt to exit)
> Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 1
> Event: time 1484879712.604360, -------------- SYN_REPORT ------------
> Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 0
> Event: time 1484879715.132228, -------------- SYN_REPORT ------------
> ...
> Check state is updated at resume time when different from suspend time.
> 
> Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2

Strip off the gerrit Change-Id: as it is meaningless upstream.

Thanks!
Benson

-- 
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
bleung@xxxxxxxxxx
Chromium OS Project
bleung@xxxxxxxxxxxx

Attachment: signature.asc
Description: OpenPGP digital signature