Re: [PATCH 13/60] staging: lustre: obdclass: health_check to report unhealthy upon LBUG

[James Simmons]

> Wat?
> 
> I'm sorry but this patch makes no sense at all.
> 
> On Sat, Jan 28, 2017 at 07:04:41PM -0500, James Simmons wrote:
> > From: Bruno Faccini <bruno.faccini@xxxxxxxxx>
> > 
> > When a LBUG has occurred, without panic_on_lbug being set,
> > health_check sysfs file must return an unhealthy state.
> 
> Why?

Its a patch being applied out of order issue. Originally this
patch was written before this was moved to sysfs and the original
code didn't return right after printing "LBUG". The move to
sysfs changed this behavior. I will fix up the out of tree code
in this case.
 
> > 
> > Signed-off-by: Bruno Faccini <bruno.faccini@xxxxxxxxx>
> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7486
> > Reviewed-on: http://review.whamcloud.com/17981
> > Reviewed-by: Bobi Jam <bobijam@xxxxxxxxxxx>
> > Reviewed-by: Niu Yawei <yawei.niu@xxxxxxxxx>
> > Reviewed-by: James Simmons <uja.ornl@xxxxxxxxx>
> > Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> > Signed-off-by: James Simmons <jsimmons@xxxxxxxxxxxxx>
> > ---
> >  drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> > index 22e6d1f..ef25db6 100644
> > --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> > +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> > @@ -224,8 +224,10 @@ static ssize_t pinger_show(struct kobject *kobj, struct attribute *attr,
> >  	int i;
> >  	size_t len = 0;
> >  
> > -	if (libcfs_catastrophe)
> > -		return sprintf(buf, "LBUG\n");
> > +	if (libcfs_catastrophe) {
> > +		len = sprintf(buf, "LBUG\n");
> 
> This line is dead code, now.
> 
> > +		healthy = false;
> > +	}
> >  
> 
> regards,
> dan carpenter
> 
>