Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

From: Jon Mason
Date: Thu Feb 02 2017 - 15:20:13 EST


On Thu, Feb 2, 2017 at 3:15 PM, RafaÅ MiÅecki <rafal@xxxxxxxxxx> wrote:
> On 2017-02-02 01:31, Zac Schroff wrote:
>>
>> How about BCMA_IOCTL_PRESERVE_ACROSS_INIT?
>
>
> I think wireless drivers may still set some these bits during init.
>
> I've a simpler idea: make it bgmac specific. Call it sth like
> BGMAC_BCMA_IOCTL_PRESERVE
> BGMAC_BCMA_IOCTL_RESERVED
> BGMAC_BCMA_IOCTL_DONT_TOUCH

Yes, I am listing out all of the fields in that register. We can be
intelligent about what we mask off :)