Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts

From: Steven Rostedt
Date: Thu Feb 02 2017 - 22:13:24 EST


On Fri, 3 Feb 2017 10:57:57 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote:
ell. sure, no objections, but in this particular case it's hardly
possible
> to hit all of those problems within a reasonable time. so what I did was just
> a bunch of dirty hacks to provoke the problems. something like this
>
> extern int XXX;
>
> vprintk_emit()
> {
> spin_lock(&logbuf_lock);
>
> //
> // in various places
> //
> if (XXX == 1) {
> WARN_ON(1);
> }
>
> spin_unlock(&logbuf_lock);
> }
>
> and I set/clear that XXX from one of sysfs attrs... yeah, I know...
> but it does what I want. so I'm not really sure I want to note this
> in the change log. am I wrong?

No you are not. But just seeing this in email does help. And yeah, this
is the type of testing that I do as well on things like this. No need
to put it in the change log.

-- Steve