Re: [PATCH 7/7] efi: Print the secure boot status in x86 setup_arch() [ver #7]

From: Ard Biesheuvel
Date: Fri Feb 03 2017 - 11:23:22 EST


On 3 February 2017 at 16:21, David Howells <dhowells@xxxxxxxxxx> wrote:
> Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
>
>> > + if (IS_ENABLED(CONFIG_EFI)) {
>>
>> Shouldn't this be a runtime check?
>
> Interesting question. The original patch I was working from had a #ifdef
> here. Possibly it doesn't need to be there at all. We could rely entirely on
> the value of boot_params.secure_boot.
>

Yes, but only if you are booting via UEFI, no? So perhaps use
efi_enabled(EFI_BOOT) instead?