Re: [PATCH] drm/panel: simple: ensure Sharp lq123p1jx31 isn't turned off too soon

From: Thierry Reding
Date: Mon Feb 06 2017 - 07:03:23 EST


On Thu, Feb 02, 2017 at 03:38:53PM -0800, Douglas Anderson wrote:
> The Sharp lq123p1jx31 has a requirement that the VDD is on for at
> least 300 ms before being turned off. At the moment nothing anywhere
> in the kernel is ensuring this.

Looks to me like .delay.prepare would be a better fit. That enables the
regulator and setting it to 300 ms would make sure that the regulator
will always get enabled for at least 300 ms.

Anyway, your commit message says nothing about why this is important.
What are the side-effects if the above isn't true? Does the display hang
in some way?

Thierry

Attachment: signature.asc
Description: PGP signature