Re: [PATCH 3/3] pinctrl: berlin: make bool drivers explicitly non-modular

From: Jisheng Zhang
Date: Tue Feb 07 2017 - 06:24:13 EST


On Mon, 6 Feb 2017 03:03:52 -0500 Paul Gortmaker wrote:

> None of the Kconfigs for any of these drivers are tristate,
> meaning that they currently are not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: "Antoine TÃnart" <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> Cc: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> Cc: Hongzhou Yang <hongzhou.yang@xxxxxxxxxxxx>
> Cc: Thomas Hebb <tommyhebb@xxxxxxxxx>
> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Acked-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>