Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

From: David Miller
Date: Tue Feb 07 2017 - 12:58:31 EST


From: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx>
Date: Mon, 6 Feb 2017 21:20:33 +0100

>
> /* Validate the protocol - only support UMTS for now */
> - if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) {
> + if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) {
...
> + } else if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS_DS) {
> + expected_length = SIERRA_NET_LSI_UMTS_DS_STATUS_LEN;

If you are now supporting more protocols, that comment is not correct
any longer. You therefore need to update it or remove it.

Thanks.