Re: [PATCH 1/2] PCI/msi: remove unused function pci_msi_create_default_irq_domain

From: Marc Zyngier
Date: Thu Feb 09 2017 - 03:54:36 EST


On 08/02/17 13:43, Thomas Gleixner wrote:
> On Fri, 3 Feb 2017, Christoph Hellwig wrote:
>
> No objections, but then we also can remove:
>
> struct irq_domain * __weak arch_get_pci_msi_domain(struct pci_dev *dev)
>
> as there are no arch specific implementations
>
> along with:
>
> static struct irq_domain *pci_msi_default_domain;
>
> because pci_msi_create_default_irq_domain() is the only place where the
> default domain is ever set.

Indeed. I'm all for dropping the "default" stuff, as it only gives
people the idea that they can get away with it (most of the time, they
cannot).

Thanks,

M.
--
Jazz is not dead. It just smells funny...