Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c

From: Ingo Molnar
Date: Fri Feb 10 2017 - 03:51:18 EST



* Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:

> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> index 8af04af..759577d 100644
> --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> @@ -27,7 +27,6 @@
> #include <linux/seq_file.h>
> #include <linux/sched.h>
> #include <linux/slab.h>
> -#include <linux/cpu.h>
> #include <linux/task_work.h>
>
> #include <uapi/linux/magic.h>

Same comment as for your other trivial patch: the list of includes in that .c file
can probably be further reduced.

I.e. instead of a mindless single liner that helps no-one, try to improve the code
for real.

Thanks,

Ingo