RE: [PATCH 05/13] vmbus: remove per channel state

From: KY Srinivasan
Date: Sun Feb 12 2017 - 00:55:41 EST




> -----Original Message-----
> From: Stephen Hemminger
> Sent: Friday, February 10, 2017 8:39 AM
> To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan
> <kys@xxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx;
> jasowang@xxxxxxxxxx; leann.ogasawara@xxxxxxxxxxxxx; Stephen
> Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Subject: RE: [PATCH 05/13] vmbus: remove per channel state
>
> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, February 10, 2017 6:47 AM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx;
> jasowang@xxxxxxxxxx; leann.ogasawara@xxxxxxxxxxxxx; Stephen
> Hemminger <stephen@xxxxxxxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>
> Subject: Re: [PATCH 05/13] vmbus: remove per channel state
>
> On Sun, Feb 05, 2017 at 05:20:35PM -0700, kys@xxxxxxxxxxxxxxxxxxxxxx
> wrote:
> > From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> >
> > The netvsc no longer needs per channel state hook to track receive buffer.
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > ---
> > include/linux/hyperv.h | 14 --------------
> > 1 files changed, 0 insertions(+), 14 deletions(-)
>
> This patch breaks the build badly, I don't know how it passed anyone's
> build tests :(
>
> The functions are still used in two different files.
>
> I've applied the first 4 patches here, but really, I shouldn't have had
> to bisect down to the offending patch.
>
> ugh.
>
> greg k-h
>
> In the set I submitted was the patch to remove usage of per channel state in
> netvsc.
> KY dropped it, because it already is in net-next. So this patch can wait until
> net-next is merged.
> The current split tree process is a pain and causes slow development cycles

Greg,

Sorry for the confusion; I will be resending the rest of the patches.

Thanks,

K. Y