Re: [PATCH] bcm2835-audio: Fix checkpatch errors

From: Greg Kroah-Hartman
Date: Sun Feb 12 2017 - 07:17:30 EST


On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
> Fix following errors:
>
> ERROR: do not initialise statics to NULL
> +static struct snd_card *g_card = NULL;
>
> ERROR: do not initialise statics to NULL
> +static struct bcm2835_chip *g_chip = NULL;
>
> Signed-off-by: Man Choy <manchoyy@xxxxxxxxx>
> ---
> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
> index a84d74d..265fe55 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
> @@ -28,8 +28,8 @@
> * to debug if we run into issues
> */
>
> -static struct snd_card *g_card = NULL;
> -static struct bcm2835_chip *g_chip = NULL;
> +static struct snd_card *g_card;
> +static struct bcm2835_chip *g_chip;
>
> static int snd_bcm2835_free(struct bcm2835_chip *chip)
> {

Someone sent this same fix in before you did, a few days ago. Be sure
to always use the most up-to-date tree.

sorry,

greg k-h