Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

From: Michael Ellerman
Date: Tue Feb 14 2017 - 15:33:38 EST




On 15 February 2017 03:14:24 GMT+11:00, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
>On 02/13/2017 07:09 PM, Michael Ellerman wrote:
>> Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes:
>>
>>> In commit 88baa78d1f31 ("selftests: remove duplicated all and clean
>>> target"), the "all" target was removed from individual Makefiles and
>>> added to lib.mk.
>>>
>>> However the "all" target was added to lib.mk *after* the existing
>>> "runtests" target. This means "runtests" becomes the first (default)
>>> target for most of our Makefiles.
>> ...
>>>
>>> Fix it by moving the "all" target to the start of lib.mk, making it
>the
>>> default target.
>>>
>>> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean
>target")
>>> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>>
>> Hi Shuah,
>>
>> Can you please merge this series into linux-next?
>>
>> The selftests are badly broken otherwise.
>>
>> cheers
>>
>
>Hi Michael,
>
>Thanks. All 5 patches are now in linux-kselftest next with Tested-by
>tag from Bamvor for 1,2,3.

Thanks!
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.