Re: [PATCH 08/11] ARM: dts: Prepare Actions Semi S500 and LeMaker Guitar

From: Mark Rutland
Date: Wed Feb 15 2017 - 12:36:39 EST


On Wed, Feb 15, 2017 at 06:28:31PM +0100, Andreas FÃrber wrote:
> Hi Mark,
>
> Am 15.02.2017 um 18:07 schrieb Mark Rutland:
> > On Wed, Feb 15, 2017 at 05:55:25PM +0100, Andreas FÃrber wrote:
> >> + arm-pmu {
> >> + compatible = "arm,cortex-a9-pmu";
> >> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> >> + <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> >> + <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> >> + <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> >> + };
> >
> > Please add an interrupt-affinity property, as described in
> > Documentation/devicetree/bindings/arm/pmu.txt
>
> That's not in the vendor tree... My guess is it would be like this then?
>
> diff --git a/arch/arm/boot/dts/s500.dtsi b/arch/arm/boot/dts/s500.dtsi
> index ee93984..959c6e3 100644
> --- a/arch/arm/boot/dts/s500.dtsi
> +++ b/arch/arm/boot/dts/s500.dtsi
> @@ -82,7 +82,8 @@
> <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> - };
> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> + };

Assuming that's how they're wired up, yes.

You should be able to test this by using perf record in per-cpu mode,
on an application with its affintiy fixed to a particular CPU, and
verifying that overflow interrupts are recevied on the same CPU.

Thanks,
Mark.