RE: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()
Date: Thu Feb 16 2017 - 02:16:10 EST
> -----Original Message-----
> From: Steven Rostedt [mailto:rostedt@xxxxxxxxxxx]
> Sent: Thursday, February 16, 2017 11:46 AM
> To: Byungchul Park
> Cc: peterz@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> juri.lelli@xxxxxxxxx; kernel-team@xxxxxxx
> Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in
> On Thu, 16 Feb 2017 11:34:17 +0900
> Byungchul Park <byungchul.park@xxxxxxx> wrote:
> > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
> > it returns a task other than NULL, which means that task_cpu(task) must
> > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
> > rq->cpu as well. Remove the redundant condition and make code simpler.
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> > Signed-off-by: Byungchul Park <byungchul.park@xxxxxxx>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> > Reviewed-by: Juri Lelli <juri.lelli@xxxxxxx>
> > ---
> This is a different patch, I don't believe Juri reviewed it yet.
I should have asked you first and been more careful before I added
'reviewed-by'. Can I ask you for your opinion about the additional one?