Re: [PATCH] ACPI, APEI: Fix BERT resources conflict with ACPI NVS area
From: Huang\, Ying
Date: Thu Feb 16 2017 - 05:24:53 EST
Borislav Petkov <bp@xxxxxxx> writes:
> On Thu, Feb 16, 2017 at 12:42:00AM +0100, Rafael J. Wysocki wrote:
>> On Tuesday, February 14, 2017 10:01:13 AM Huang, Ying wrote:
>> > From: Huang Ying <ying.huang@xxxxxxxxx>
>> > It was reported that some firmware will use ACPI NVS area for BERT
>> > address range. This will cause resources conflict because the ACPI
>> > NVS area is marked as busy already. Fix this via excluding ACPI NVS
>> > area when requesting IO resources for BERT.
>> > Reported-and-tested-by: Hans Kristian Rosbach <hansr@xxxxxxxxxxxxx>
>> > Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
>> Boris, what do you think?
> Lemme see, so the BERT is for hw errors which have happened during the
> previous boot and the machine couldn't handle them. So they do get saved
> in some mem in the fw for inspection during the next boot.
> And "some firmware" has decided to write them into non-volatile storage
> - because you should never ever forget those errors! :-)
> And I don't understand the "fix" here: we're excluding the NVS area when
> mapping the BERT table but then how are we supposed to read those errors
> from there?
The NVS area is excluded when request the resources, because the NVS
area has been marked as busy already. But the whole BERT memory area is
mapped, so we can read from it.
> Or am I missing something obvious?