Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits
From: Thomas Gleixner
Date: Thu Feb 16 2017 - 13:07:51 EST
On Tue, 14 Feb 2017, Andrew Banman wrote:
> The location of the ERROR and BUSY status bits depends on the descriptor
> index, i.e. the CPU, of the message. We determine this location ahead of
> the wait_completion loop to avoid repeating the calculation.
> Split out the status location calculation into a new routine,
> status_mmr_loc, to be used within each uv*_wait_completion routine.
And the reason for this is? You just tell WHAT you are doing, not the WHY.
Looking at the patch which implements the uv4 wait function it uses the
thing as well. So for the casual reader there is no point.
The only reason i figured why you want to do that is to reduce the number
of arguments to the wait function, correct?
If yes, then spell it out. If no, please enlighten me.