Re: [PATCH 3/6] x86/platform/uv/BAU: Add wait_completion to bau_operations

From: Thomas Gleixner
Date: Thu Feb 16 2017 - 13:12:01 EST

On Tue, 14 Feb 2017, Andrew Banman wrote:

> Remove the present wait_completion routine and add a function pointer by
> the same name to the bau_operations struct. Rather than switching on the
> UV hub version during message processing, set the architecture-specific
> uv*_wait_completion during initialization.

Well written changelog!

> +static int uv1_wait_completion(struct bau_desc *bau_desc,
> + struct bau_control *bcp, long try);
> +static int uv2_3_wait_completion(struct bau_desc *bau_desc,
> + struct bau_control *bcp, long try);

You could spare the forward declarations by moving the uv*_bau_ops down
right before uv_bau_init(). And while at it, the uv*_bau_ops can be made

> static struct bau_operations ops;

That one can be made __ro_after_init as the only possible modification
happens in the init function.