Re: [PATCH v3 5/6] ARM: mvebu: Add driver for mv98dx3236-soc-id
From: Chris Packham
Date: Thu Feb 16 2017 - 23:23:28 EST
On 17/02/17 02:28, Arnd Bergmann wrote:
> On Thursday, February 16, 2017 9:50:39 PM CET Chris Packham wrote:
>> The DFX server on the 98dx3236 and compatible SoCs has an ID register
>> that provides revision information that the PCI based ID register
>> doesn't have. Use this if it's available.
>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> How about putting this new code into a separate driver in
> drivers/soc/? I don't think you need the early probing we have
> here, and not that much is shared otherwise.
Not putting it there means we'll get the pci fall-back behaviour which
will result in a incorrect rev value. Having said that no callers of
mvebu_get_soc_id() currently care about these specific SoCs so not
having the right rev is not an issue at the moment.