Re: [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for configuring EP functions
From: Kishon Vijay Abraham I
Date: Fri Feb 17 2017 - 07:01:50 EST
On Friday 17 February 2017 03:20 PM, Kishon Vijay Abraham I wrote:
> Introduce a new configfs entry to configure the EP function (like
> configuring the standard configuration header entries) and to
> bind the EP function with EP controller.
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> drivers/pci/endpoint/Kconfig | 14 +-
> drivers/pci/endpoint/Makefile | 1 +
> drivers/pci/endpoint/pci-ep-cfs.c | 427 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 440 insertions(+), 2 deletions(-)
> create mode 100644 drivers/pci/endpoint/pci-ep-cfs.c
> diff --git a/drivers/pci/endpoint/Kconfig b/drivers/pci/endpoint/Kconfig
> index 7eb1c79..8470f0b 100644
> --- a/drivers/pci/endpoint/Kconfig
> +++ b/drivers/pci/endpoint/Kconfig
> @@ -6,7 +6,6 @@ menu "PCI Endpoint"
> config PCI_ENDPOINT
> bool "PCI Endpoint Support"
> - select CONFIGFS_FS
> Enable this configuration option to support configurable PCI
> endpoint. This should be enabled if the platform has a PCI
> @@ -14,8 +13,19 @@ config PCI_ENDPOINT
> Enabling this option will build the endpoint library, which
> includes endpoint controller library and endpoint function
> - library.
> + library. This will also enable the configfs entry required to
> + configure the endpoint function and used to bind the
> + function with a endpoint controller.
This chunk shouldn't be added. I've missed removing this (it's added below).
I'll wait to get other review comments before sending a new revision.