Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data
From: Krzysztof Kozlowski
Date: Fri Feb 17 2017 - 08:35:15 EST
On Thu, Feb 16, 2017 at 01:27:16PM +0000, Charles Keepax wrote:
> Use devm_gpiochip_add_data to simplify the error path in
> samsung_gpiolib_register. Additionally this would also fix a leak if
> the pinctrl driver was unbound, although admittedly I can't see any
> good use-case for doing so, but the driver does currently allow it.
Driver does not allow unbinding (.suppress_bind_attrs = true)...
Regardless of this:
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>