Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

From: Larry Finger
Date: Fri Feb 17 2017 - 11:42:29 EST


On 02/17/2017 10:19 AM, Geert Uytterhoeven wrote:
Hi Larry,

On Fri, Feb 17, 2017 at 5:14 PM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote:
As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky
register acronym, but a simple misspelling of "write".

Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Cc: Chaoming Li <chaoming_li@xxxxxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx

I'm not sure that it is possible to have a typo in a variable name. That
seems to be within an author's prerogative. Nonetheless, the patch is OK

;-)

other than it was sent to the wrong destination. Patches for this driver

MAINTAINERS has your name for drivers/net/wireless/realtek/rtlwifi/.
Perhaps that line should be dropped?

The usual hierarchy is through me to Kalle, then to DaveM, and finally to mainline.

should go through linux-wireless@xxxxxxxxxxxxxxxx Kalle Valo is the wireless
maintainer, but it is not necessary to send to him directly as he usually
picks up the patches from Patchwork.

I guess Jiri (trivial) will pick it up...

The only potential problem would be conflicts arising from changes merging from two different directions. It applies to Kalle's wireless-drivers-next branch, and I will try to keep it in mind as additional patches are supplied to rtl8821ae.

Larry