Re: [PATCH] [media] Staging: media/lirc: don't call put_ir_rx on rx twice
From: Dan Carpenter
Date: Fri Feb 17 2017 - 17:12:49 EST
This one is a false positive. The original code is correct.
I was looking through my mail boxes to see the history of this and why
it hadn't been fixed earlier. Someone tried to fix it in 2011:
Then I complained about it again in 2014 when I was looking at a
different bug in that same function. Now you're the third person to
think this code is suspicious.
I think part of the problem is that get_ir_rx(ir) is hidden as a
function parameter instead of on its own line. But really even that
wouldn't totally fix the issue.