Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

From: Andrew Lunn
Date: Fri Feb 17 2017 - 17:37:04 EST

> Note that we are very close from 4.10, so unless there is a major issue
> in the patchset, I'd prefer not to respin new versions. I'd gladly send
> cosmetics fixup later though. I'm waiting for this patchset to land in
> net-next to send the second one ready for cross-chip bridging in DSA.

I know we are very close to v4.10. But i don't think these changes
alone make the 6390 work properly. It appears that we still have:

if (mv88e6xxx_6352_family(chip) || mv88e6xxx_6351_family(chip) ||
mv88e6xxx_6165_family(chip) || mv88e6xxx_6097_family(chip) ||
mv88e6xxx_6320_family(chip) || mv88e6xxx_6341_family(chip)) {
/* Port ATU control: disable limiting the number of
* address database entries that this port is allowed
* to use.
err = mv88e6xxx_port_write(chip, port, PORT_ATU_CONTROL,
/* Priority Override: disable DA, SA and VTU priority
* override.
err = mv88e6xxx_port_write(chip, port, PORT_PRI_OVERRIDE,
if (err)
return err;

to deal with. I have been working on 6390 for a long time, and would
like to see it working properly, but i'm not happy with the
non-obvious changes here, and the structure of these patches.

Please take your time to do this right. Lots of small patches, which
are obviously correct.