Re: [PATCH] RDMA/qedr: Fix some error handling

From: Doug Ledford
Date: Sun Feb 19 2017 - 08:59:46 EST


On Sat, 2017-02-18 at 12:28 +0100, Christophe JAILLET wrote:
> 'qedr_alloc_pbl_tbl()' can not return NULL.
>
> In qedr_init_user_queue():
> Â- simplify the test for the return value, no need to test for NULL
> Â- propagate the error pointer if needed, otherwise 0 (success) is
> returned.
> ÂÂ This is spurious.
>
> In init_mr_info():
> Â- test the return value with IS_ERR
> Â- propagate the error pointer if needed instead of an exlictit
> -ENOMEM.
> ÂÂ This is a no-op as the only error pointer that we can have here is
> ÂÂ already -ENOMEM
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Thanks, applied.

--
Doug Ledford <dledford@xxxxxxxxxx>
  GPG KeyID: B826A3330E572FDD
 Â
Key fingerprint = AE6B 1BDA 122B 23B4 265B Â1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part