Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation
From: Pavel Machek
Date: Sun Feb 19 2017 - 14:05:59 EST
> Hi Pavel,
> I love discussions with you :)
Unfortunately I can't say the same.
> > Am 19.02.2017 um 18:15 schrieb Pavel Machek <pavel@xxxxxx>:
> >>> Solve it properly. That means passing calibration
> >>> data from kernel to userland.
> >> As written before, the really proper solution would be to provide floating
> >> or fixed point subpixel input events. Not arbitrarily scaling up in kernel
> >> and leaving downscaling to user space (where everybody can make it
> >> worse).
> > That has no advantages,
> It has the advantage of providing you with the full precision of raw data (but
> properly scaled) so that you don't loose any bit of information. This is what
> you just asked for - one or two mails before.
Not really, right? No matter what kind of fixed point you introduce,
you'll still loose precision.
> > and floating point in kernel is hard. Also
> > you'd either have to invent new interface, or you'd break touchscreen
> > for people that already have their touchscreens calibrated.
> No, I don't break calibration for people using a different chip.
So you propose your touchscreen to behave differently from all other
touchscreens in tree? That's just no-go.
> > Yes, that's not really proper solution, that just overengineered. Not
> > worth implementing. Pass calibration data to userland.
> You seem to repeat yourself and just say which solution you prefer,
> but I am missing the arguments why your solution (Pass calibration data
> to userland) is right and the best one.
> Which problems does it solve?
All you described.
> Which one does it solve better than others?
It is not terminally ugly.
> How can you implement it in
> a stable and portable way?
> How can you make sure that all user-space GUI
> systems can and will make use of this calibration data?
You can't, and you don't need to.
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Description: Digital signature