Re: [Outreachy kernel] Re: [PATCH 1/2] staging: ks7010: Unnecessary parentheses are removed.
From: Julia Lawall
Date: Sun Feb 19 2017 - 14:20:12 EST
On Sun, 19 Feb 2017, Joe Perches wrote:
> On Sun, 2017-02-19 at 19:58 +0100, Julia Lawall wrote:
> > On Sun, 19 Feb 2017, Joe Perches wrote:
> > > On Sun, 2017-02-19 at 23:56 +0530, Arushi Singhal wrote:
> > > > Unnecessary parentheses should be avoided as reported by checkpatch.pl.
> > > > Remove unnecessary parentheses, as reported by checkpatch as are nicer
> > > > to read.For example:-
> > > > It's often nicer to read if &(foo) is converted to foo like:
> > > > memcpy(&(ap->bssid), &(ap_info->bssid), ETH_ALEN);
> > > > memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
> > > 
> > > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> > > 
> > > > @@ -212,7 +212,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct ap_info_t *ap_info,
> > > > memset(ap, 0, sizeof(struct local_ap_t));
> > > >
> > > > /* bssid */
> > > > - memcpy(&(ap->bssid), &(ap_info->bssid), ETH_ALEN);
> > > > + memcpy(&ap->bssid, &ap_info->bssid, ETH_ALEN);
> > >
> > > This code doesn't match the suggested style of
> > > your commit message.
> > Is what is suggested in the commit message correct? That is, is the 0th
> > element of an array always at the same address as a pointer to the array
> > itself?
> I think your wording is a little fuzzy.
> Assuming you mean not a pointer to the array,
> but the array itself, yes.
Yes, I mean the array itself,sorry. Thanks.
Arushi, it would be good it you could make the change you proposed to
make. The calls would look much more normal that way.
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1487531915.2198.38.camel%40perches.com.
> For more options, visit https://groups.google.com/d/optout.