Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation
From: Pavel Machek
Date: Sun Feb 19 2017 - 17:40:40 EST
> > > And note that I am not making things different from others in tree,
> > > I am making the tsc2007 right (incl. following the touchscreen
> > > bindings which define the touchscreen size in "Pixels").
> > Your touch screen is not in any way special, so it has to behave in
> > the same way others do.
> I agree, the tsc2007 (=what the interface provides to userspace) should
> not behave special, for example it should behave like the virtual
> touchscreen (=what the interface provides to userspace) virtualbox
> gives. No need to be calibrated. Well, the internals are different. But
> that is what the kernel is good for, abstract such things.
> Conclusion: It cannot be totally wrong behavior to have pixel values
It is not "totally wrong". But it is useless code that should not be
in kernel. Calibration certainly does not belong to single
_driver_. Feel free to submit driver but keep the calibration code out
But if you have userspace that depends on touchscreen to be
calibrated... that _is_ wrong.
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Description: Digital signature