Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C
From: Andy Shevchenko
Date: Mon Feb 20 2017 - 06:55:43 EST
On Mon, Feb 20, 2017 at 11:32 AM, Eva Rachel Retuya <eraretuya@xxxxxxxxx> wrote:
> On Mon, Feb 20, 2017 at 02:41:12PM +0800, Eva Rachel Retuya wrote:
>> On Sun, Feb 19, 2017 at 01:11:29PM +0000, Jonathan Cameron wrote:
>> > On 16/02/17 10:02, Eva Rachel Retuya wrote:
>> Hello Jonathan,
>> Thanks for the feedback. I amended the relevant commits as you say and
>> git detects the file adxl345.c -> adxl345_core.c as 78% renamed. The
>> reason for that percentage is that I did some probe/remove renames and
>> some other deletions here and there. Should I commit them separately in
>> order to get the move detection to work?
> Moved the deletions/modifications into patch 1. I hope I got it right
> this time?
I'm not a Jonathan, but there my remarks.
1. Yes, this version looks better.
2. Just a hint: check -M (for move) and -C (for copy) parameters to
3. And please avoid over quoting when answering mails.
With Best Regards,