Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon
From: Marc Kleine-Budde
Date: Mon Feb 20 2017 - 11:45:10 EST
On 02/20/2017 05:37 PM, Alexandre Belloni wrote:
> On 19/02/2017 at 16:37:50 +0100, Oliver Hartkopp wrote:
>> Fortunately I was contacted by Bosch this Friday as they want to contribute
>> a driver upgrade to support IP cores up to 3.2.x.
>> Additionally their plan is to use Device Tree information to determine the
>> IP core revision - or at least to cross check its information with the
>> register information used in your suggestion.
> My opinion is that is is not really useful. Either we use the version
> info from the register or DT. But that is probably a matter of taste and
> you are the maintainer :)
I see no benefit of holding the version number in the DT, as long as the
version of the HW can be auto discovered properly.
>> For that reason I would suggest to wait for the driver updates from Bosch
>> instead of adding an incomplete fix for only one change of eleven.
> Well, having something working right now is still better that nothing. I
> think it is worth having that patch now so CAN is working on our
> Everything else can probably be built on top of it anyway.
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Description: OpenPGP digital signature