Re: [RFC 1/1] shiftfs: uid/gid shifting bind mount

From: James Bottomley
Date: Mon Feb 20 2017 - 19:49:04 EST

On Tue, 2017-02-07 at 01:24 +0900, J. R. Okajima wrote:
> James Bottomley:
> > Yes, I know the problem. However, I believe most current linux
> > filesystems no longer guarantee stable, for the lifetime of the
> > file, inode numbers. The usual docker container root is overlayfs,
> > which, similarly doesn't support stable inode numbers. I see the
> > odd complaint about docker with overlayfs having unstable inode
> > numbers, but none seems to have any serious repercussions.
> I think it serious.
> Reusing the backend fs' inum is a good approach which Amir wrote.
> Based on this, I'd suggest you to support the hardlinks.

I realised as I was trimming down the vestigial inode properties in the
patch that actually shiftfs does use the i_ino from the underlying for
userspace. The reason why is that it comes from the getattr call in
stat and that's fully what the underlying filesystem returns (including
the inode number).