Re: [PATCH] drm: drm_printer: add __printf validation
From: Jani Nikula
Date: Tue Feb 21 2017 - 03:30:27 EST
On Mon, 20 Feb 2017, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Mon, 2017-02-20 at 12:17 +0000, Eric Engestrom wrote:
>> On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote:
>> > drm_printf does not currently use the compiler to verify
>> > format and arguments. Make it do so.
>> > Miscellanea:
>> > o Add appropriate #include files for __printf and struct va_format
>> > o Convert dev_printk to dev_info
>> I think these unrelated changes should be in 4 patches:
>> 1 - add annotation to check the format string against the arguments
>> (linux/compiler.h should be added here)
>> 2 - add missing linux/printk.h header for struct va_format
>> Note that I think a forward declaration is more appropriate here, as
>> we only use pointers to this struct in this file, we never try to
>> look inside. On the other hand:
>> 3 - drm_print.c needs the header in drm_printf(), but as a separate
>> 4 - convert dev_printk to dev_info (you need to include linux/device.h
> I am not a big fan of making trivial patches into a series.
It's standard procedure in kernel development to split out unrelated
changes into individual patches, regardless of whether you think they
are trivial or not. Four is probably excessive, but you get the idea.
>> You can add my r-b on all four patches when you send them to the list :)
> If you want to break it up, go ahead.
You know how this stuff works, please split it up to get the stuff
Jani Nikula, Intel Open Source Technology Center