[PATCH 4.4 12/15] NTB: ntb_transport: fix debugfs_remove_recursive

From: Greg Kroah-Hartman
Date: Tue Feb 21 2017 - 08:02:44 EST

4.4-stable review patch. If anyone has any objections, please let me know.


From: Allen Hubbe <Allen.Hubbe@xxxxxxxx>

commit dd62245e73de9138333cb0e7a42c8bc1215c3ce6 upstream.

The call to debugfs_remove_recursive(qp->debugfs_dir) of the sub-level
directory must not be later than
debugfs_remove_recursive(nt_debugfs_dir) of the top-level directory.
Otherwise, the sub-level directory will not exist, and it would be
invalid (panic) to attempt to remove it. This removes the top-level
directory last, after sub-level directories have been cleaned up.

Signed-off-by: Allen Hubbe <Allen.Hubbe@xxxxxxxx>
Fixes: e26a5843f ("NTB: Split ntb_hw_intel and ntb_transport drivers")
Signed-off-by: Jon Mason <jdmason@xxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/ntb/ntb_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -2082,9 +2082,8 @@ module_init(ntb_transport_init);

static void __exit ntb_transport_exit(void)
- debugfs_remove_recursive(nt_debugfs_dir);
+ debugfs_remove_recursive(nt_debugfs_dir);