Re: [PATCH] dma-buf: add support for compat ioctl

From: Christian KÃnig
Date: Tue Feb 21 2017 - 08:59:40 EST

Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data structures for both 32
and 64bit modes are same, so there is no need for additional translation

Well I might be wrong, but IIRC compat_ioctl was just optional and if not specified unlocked_ioctl was called instead.

If that is true your patch wouldn't have any effect at all.


Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
drivers/dma-buf/dma-buf.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 718f832a5c71..0007b792827b 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -325,6 +325,9 @@ static long dma_buf_ioctl(struct file *file,
.llseek = dma_buf_llseek,
.poll = dma_buf_poll,
.unlocked_ioctl = dma_buf_ioctl,
+ .compat_ioctl = dma_buf_ioctl,