Re: [PATCH] staging/ks7010: formatting updates.
From: Joe Perches
Date: Tue Feb 21 2017 - 15:03:00 EST
On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote:
> * Joe Perches <joe@xxxxxxxxxxx> [2017-02-21 10:47:31 -0800]:
> > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> > > * Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> [2017-02-21 15:22:10 +0100]:
> > >
> > > > The first declaration fit nicely on a single line.
> > > > The second one indeed has a few spaces instead of TABs in the
> > > > continuation line. But that can be fixed easily, without moving the
> > > > first parameter to a continuation line.
> > >
> > > What would the proposed fix be? A combination of spaces and hard-tabs? I
> > > don't see checkpatch complaining about it, so that could work too.
> > Maximal initial tabs, followed by required spaces to align
> > to open parenthesis
> Thank you Joe. I will change it accordingly. Is there a supplementary
> style guide that covers these finer details?
No, coding style just says
Descendants are always substantially shorter than
the parent and are placed substantially to the right
However alignment to the open parenthesis is a
pretty common style.