Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference
From: Valentin Rothberg
Date: Wed Feb 22 2017 - 03:30:56 EST
On Feb 21 '17 09:22, Joe Perches wrote:
> On Wed, 2017-02-22 at 00:31 +0800, Cheah Kok Cheong wrote:
> > > Another option could be using the typedefs from include/linux/types.h,
> > > e.g. ushort. However, this might require changing other declarations as
> > > well to keep consistency.
> > Thanks for the idea. I counted seven instances of 'unsigned short'
> > in this file so it's not viable for our situation.
> I believe using ushort is relatively undesirable as
> "unsigned short" is preferred ~10:1 in the kernel
Wow, that is suprising to me considering the 80 character limit. Thanks
for pointing this out!
> $ git grep -w ushort | wc -l
> $ git grep -E "\bunsigned\s+short\b" | wc -l
> $ git grep --name-only -w "ushort" | wc -l
> $ git grep --name-only -E "\bunsigned\s+short\b" | wc -l