Re: [PATCH] net/dccp: fix use after free in tw_timer_handler()
From: Andrey Ryabinin
Date: Wed Feb 22 2017 - 04:34:55 EST
On 02/21/2017 09:24 PM, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 21 Feb 2017 13:23:51 -0500 (EST)
>> From: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
>> Date: Tue, 21 Feb 2017 14:27:40 +0300
>>> DCCP doesn't purge timewait sockets on network namespace shutdown.
>>> So, after net namespace destroyed we could still have an active timer
>>> which will trigger use after free in tw_timer_handler():
>>> Add .exit_batch hook to dccp_v4_ops()/dccp_v6_ops() which will purge
>>> timewait sockets on net namespace destruction and prevent above issue.
>>> Reported-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
>>> Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
>> Applied and queued up for -stable, thanks.
> Actually, this doesn't even compile. Please fix this up and resubmit:
Right, I tested this on top of the Linus' tree. Rebased on -next now.