Re: [PATCH 4/4] mm,hugetlb: compute page_size_log properly

From: Michal Hocko
Date: Wed Feb 22 2017 - 11:23:58 EST


On Wed 22-02-17 08:03:19, Davidlohr Bueso wrote:
> On Mon, 20 Feb 2017, Michal Hocko wrote:
>
> > I am not sure I understand.
> > $ git grep SHM_HUGE_ include/uapi/
> > $
> >
> > So there doesn't seem to be any user visible constant. The man page
> > mentiones is but I do not really see how is the userspace supposed to
> > use it.
>
> Yeah, userspace is not supposed to use it, it's just there because
> the manpage describes kernel internals.

Which is wrong!

> I'm not really a big fan
> of touching manpages (and ipc is already full of corner cases),
> but I guess nobody can really complain if we rip out all the
> SHM_HUGE_ stuff.

yeah, let's just get rid of it.
--
Michal Hocko
SUSE Labs