Re: [PATCH] score: Add missing include files

From: Guenter Roeck
Date: Wed Feb 22 2017 - 14:59:04 EST


On Wed, Feb 22, 2017 at 02:46:33PM -0500, Paul Gortmaker wrote:
> [[PATCH] score: Add missing include files] On 22/02/2017 (Wed 11:07) Guenter Roeck wrote:
>
> > Kernel builds fail with
> >
> > arch/score/kernel/traps.c: In function 'do_ri':
> > arch/score/kernel/traps.c:248:4: error:
> > implicit declaration of function 'user_disable_single_step'
> > arch/score/mm/extable.c: In function 'fixup_exception':
> > arch/score/mm/extable.c:32:38: error:
> > dereferencing pointer to incomplete type
> > arch/score/mm/extable.c:34:24: error:
> > dereferencing pointer to incomplete type
> >
> > Fixes: 0f296af85be8 ("score: migrate exception table users off ...")
>
> Not surprising, neither me/korg[1] nor kbuild nor linux-next have score
> tc for build coverage, so score got the "this looks right" treatment.
>
> Too bad your coverage didn't use linux-next over the last couple weeks,
> as then it could have been in the pull request I'd just sent. Oh well.
>
It did, and it reported it, but reports are manual and unfortunately
I don't always have time for an immediate bisect.

> Mind if I ask where you got your toolchain? I'm not in a position to
> futz around trying to build one myself for some of these less common
> architectures, but I'm not against extending my coverage using existing
> toolchains.
>
I use http://server.roeck-us.net/toolchains/score.tgz, which I picked up
from the internet some time ago (don't ask me where).

Guenter