Re: [PATCH] uapi: fix linux/if.h userspace compilation errors
From: David Miller
Date: Wed Feb 22 2017 - 16:10:53 EST
From: "Dmitry V. Levin" <ldv@xxxxxxxxxxxx>
Date: Tue, 21 Feb 2017 23:19:14 +0300
> On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote:
>> From: "Dmitry V. Levin" <ldv@xxxxxxxxxxxx>
>> Date: Mon, 20 Feb 2017 14:58:41 +0300
>> > Include <sys/socket.h> (guarded by ifndef __KERNEL__) to fix
>> > the following linux/if.h userspace compilation errors:
>> Wouldn't it be so much better to do this in include/uapi/linux/socket.h?
> Yes, it would be nicer if we could afford it. However, changing
> uapi/linux/socket.h to include <sys/socket.h> is less conservative than
> changing every uapi header that fails to compile because of its use
> of struct sockaddr. It's risky because <sys/socket.h> pulls in other
> types that might conflict with definitions provided by uapi headers.
Ok, I'll apply this for now.